-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update copyright notice for year 2023 #43
Conversation
Requires #44 to pass the |
I agree. The actively maintained projects I am aware of routinely update copyright years in their code bases. |
A test is failing with a tox error (https://github.com/bancaditalia/black-it/actions/runs/4439064630/jobs/7807435541#step:6:15):
But tox.ini seems to be ok:
[allowlist_externals documentation] (https://tox.wiki/en/latest/config.html#allowlist_externals) says that the directive should be used for commands that lie outside the tox environment, which should not be the case here. |
This behaviour is due by tox v4. On CI we do not have constraints on |
e726237
to
c95f125
Compare
@muxator, I rebased the PR branch on To be merged after #46 . |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
=======================================
Coverage 96.82% 96.82%
=======================================
Files 30 30
Lines 1512 1512
=======================================
Hits 1464 1464
Misses 48 48
|
c95f125
to
5db2501
Compare
I also agree with the change. We are still developing the package in 2023, and as such we should update the copyright notice. Well done! |
5db2501
to
c6114e4
Compare
Proposed changes
This PR updates the copyright notice, by including year 2023 as the end of the range.
Do you agree with me on this change? It is true that there should be a purpose when updating the copyright notice (e.g. when the software is going to non-trivially change), but we already did several changes since the beginning of the year, and it makes sense since we are going to do another release not so far in the future.
This is a nice discussion IMHO: https://opensource.stackexchange.com/questions/6389/how-do-the-years-specified-in-a-copyright-statement-work/6393#6393?newreg=44243af16b114eeda2b361bbfdbaf162