Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copyright notice for year 2023 #43

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Conversation

marcofavoritobi
Copy link
Contributor

@marcofavoritobi marcofavoritobi commented Mar 16, 2023

Proposed changes

This PR updates the copyright notice, by including year 2023 as the end of the range.

Do you agree with me on this change? It is true that there should be a purpose when updating the copyright notice (e.g. when the software is going to non-trivially change), but we already did several changes since the beginning of the year, and it makes sense since we are going to do another release not so far in the future.

This is a nice discussion IMHO: https://opensource.stackexchange.com/questions/6389/how-do-the-years-specified-in-a-copyright-statement-work/6393#6393?newreg=44243af16b114eeda2b361bbfdbaf162

@marcofavoritobi
Copy link
Contributor Author

Requires #44 to pass the docs workflow.

@muxator
Copy link

muxator commented Mar 17, 2023

I agree. The actively maintained projects I am aware of routinely update copyright years in their code bases.

@muxator
Copy link

muxator commented Mar 17, 2023

A test is failing with a tox error (https://github.com/bancaditalia/black-it/actions/runs/4439064630/jobs/7807435541#step:6:15):

 spell_check: failed with /home/runner/work/black-it/black-it/scripts/spell-check.sh (resolves to /home/runner/work/black-it/black-it/scripts/spell-check.sh) is not allowed, use allowlist_externals to allow it
  spell_check: FAIL code 1 (1.26 seconds)
  evaluation failed :( (1.35 seconds)
Error: Process completed with exit code 1.

But tox.ini seems to be ok:

[testenv:spell_check]
skip_install = True
deps =
commands = {toxinidir}/scripts/spell-check.sh --report

[allowlist_externals documentation] (https://tox.wiki/en/latest/config.html#allowlist_externals) says that the directive should be used for commands that lie outside the tox environment, which should not be the case here.

@marcofavoritobi
Copy link
Contributor Author

A test is failing with a tox error (https://github.com/bancaditalia/black-it/actions/runs/4439064630/jobs/7807435541#step:6:15):

 spell_check: failed with /home/runner/work/black-it/black-it/scripts/spell-check.sh (resolves to /home/runner/work/black-it/black-it/scripts/spell-check.sh) is not allowed, use allowlist_externals to allow it
  spell_check: FAIL code 1 (1.26 seconds)
  evaluation failed :( (1.35 seconds)
Error: Process completed with exit code 1.

But tox.ini seems to be ok:

[testenv:spell_check]
skip_install = True
deps =
commands = {toxinidir}/scripts/spell-check.sh --report

[allowlist_externals documentation] (https://tox.wiki/en/latest/config.html#allowlist_externals) says that the directive should be used for commands that lie outside the tox environment, which should not be the case here.

This behaviour is due by tox v4. On CI we do not have constraints on tox version, hence the latest was installed:

04df950

@marcofavoritobi
Copy link
Contributor Author

marcofavoritobi commented Mar 17, 2023

A test is failing with a tox error (https://github.com/bancaditalia/black-it/actions/runs/4439064630/jobs/7807435541#step:6:15):

 spell_check: failed with /home/runner/work/black-it/black-it/scripts/spell-check.sh (resolves to /home/runner/work/black-it/black-it/scripts/spell-check.sh) is not allowed, use allowlist_externals to allow it
  spell_check: FAIL code 1 (1.26 seconds)
  evaluation failed :( (1.35 seconds)
Error: Process completed with exit code 1.

But tox.ini seems to be ok:

[testenv:spell_check]
skip_install = True
deps =
commands = {toxinidir}/scripts/spell-check.sh --report

[allowlist_externals documentation] (https://tox.wiki/en/latest/config.html#allowlist_externals) says that the directive should be used for commands that lie outside the tox environment, which should not be the case here.

@muxator, I rebased the PR branch on chore/upgrade-deps, which contains several fixes related to dependencies. In particular, the one regarding tox: aec03e9.

To be merged after #46 .

@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2023

Codecov Report

Merging #43 (c6114e4) into main (a03363f) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #43   +/-   ##
=======================================
  Coverage   96.82%   96.82%           
=======================================
  Files          30       30           
  Lines        1512     1512           
=======================================
  Hits         1464     1464           
  Misses         48       48           
Impacted Files Coverage Δ
black_it/__init__.py 100.00% <ø> (ø)
black_it/calibrator.py 97.48% <ø> (ø)
black_it/loss_functions/__init__.py 100.00% <ø> (ø)
black_it/loss_functions/fourier.py 100.00% <ø> (ø)
black_it/loss_functions/gsl_div.py 100.00% <ø> (ø)
black_it/loss_functions/likelihood.py 85.41% <ø> (ø)
black_it/loss_functions/minkowski.py 100.00% <ø> (ø)
black_it/loss_functions/msm.py 86.88% <ø> (ø)
black_it/plot/__init__.py 100.00% <ø> (ø)
black_it/plot/plot_descriptive_statistics.py 100.00% <ø> (ø)
... and 19 more

@AldoGl
Copy link
Contributor

AldoGl commented Mar 20, 2023

I also agree with the change. We are still developing the package in 2023, and as such we should update the copyright notice. Well done!

@marcofavoritobi marcofavoritobi merged commit 9ecca12 into main Mar 20, 2023
@AldoGl AldoGl deleted the update-copyright-year branch March 20, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants