Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update PR request template #42

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Conversation

marcofavoritobi
Copy link
Contributor

Proposed changes

In the PR request template, and in particular in the checklist section, we should refer to the main branch since we are not using the develop branch anymore.

Fixes

n/a

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Further comments

n/a

In the checklist, we should refer to the `main` branch since we are not using
the `develop` branch anymore.
@muxator muxator merged commit 408fa7c into main Mar 17, 2023
@muxator muxator deleted the chore/update-pr-template branch March 17, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants