Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox.ini refactoring #41

Merged
merged 2 commits into from
Mar 17, 2023
Merged

tox.ini refactoring #41

merged 2 commits into from
Mar 17, 2023

Conversation

marcofavoritobi
Copy link
Contributor

Proposed changes

This PR applies two major changes to the tox.ini specification.

  • 1f26c4a: This commit fixes a subtle bug: "commands:" is replaced by "commands = " in py3.8-nb env. Before this change, the commands configuration was not actually overwritten. The CI did not fail because the test execution defaulted to testenv...
  • 3cc3bf4: use py3{py-minor-version} format rather than py3.{py-minor-version} for testenv names. This convention is more "tox-friendly", since an environment with 'py$MAJOR$MINOR' in its name will use the Python interpreter at version $MAJOR.MINOR as base python. In particular, in this way, we could avoid the repetition of different testenv configurations which only differ by the basepython variable. This change required a workaround in the GitHub Actions workflow configuration,

Fixes

n/a

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Further comments

n/a

This commit fixes a bug in tox.ini. "commands:" is replaced by "commands = "
in py3.8-nb env. Before this change, the commands configuration was not actually
overwritten.
…ion} for testenv names

This convention is more "tox-friendly", since an environment with 'py$MAJOR$MINOR'
in its name will use the Python interpreter at version $MAJOR.MINOR as base python.

In particular, in this way, we could avoid the repetition of different testenv
configurations which only differ by the basepython variable.

This change required a workaround in the GitHub Actions workflow configuration,
since the Python version there has a dot that separates major and minor versions.
@muxator muxator merged commit 186ece6 into main Mar 17, 2023
@muxator muxator deleted the fix/tox-ini-refactoring branch March 17, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants