samplers: add MLSurrogateSampler base class #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AldoGl
force-pushed
the
add_surrogate_sampler_class
branch
3 times, most recently
from
750e470 to
16affa9
Compare
AldoGl
force-pushed
the
add_surrogate_sampler_class
branch
from
16affa9 to
a4f4895
Compare
AldoGl
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
==========================================
+ Coverage 97.14% 97.21% +0.07%
==========================================
Files 28 29 +1
Lines 1434 1435 +1
==========================================
+ Hits 1393 1395 +2
+ Misses 41 40 -1
|
…l docstring improvements
tests/test_calibrator.py
Outdated
Comment on lines
138
to
139
| print(params) | ||
| print(losses) |
There was a problem hiding this comment.
Yes! Well spotted, thanks!
marcofavoritobi
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add a base class for all machine learning surrogates.