-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CORS sampler #28
Merged
Merged
Add CORS sampler #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
==========================================
- Coverage 97.72% 89.68% -8.04%
==========================================
Files 23 25 +2
Lines 1231 1416 +185
==========================================
+ Hits 1203 1270 +67
- Misses 28 146 +118
|
AldoGl
force-pushed
the
k-k_sampler
branch
3 times, most recently
from
December 1, 2022 12:44
432be3f
to
5abb3c2
Compare
AldoGl
force-pushed
the
k-k_sampler
branch
2 times, most recently
from
December 2, 2022 14:21
805dec1
to
aa92861
Compare
lint: black and vulture on cors sampler f
marcofavoritobi
approved these changes
Dec 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the CORS sampler to Black-it.
Reference to the CORS sampler:
Regis, Rommel G., and Christine A. Shoemaker. "Constrained global optimization of expensive black box functions using radial basis functions." Journal of Global optimization 31.1 (2005): 153-171.
The PR also changes the name of black-it.utils.assert_ to black-it.utils._assert