Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CORS sampler #28

Merged
merged 4 commits into from
Dec 2, 2022
Merged

Add CORS sampler #28

merged 4 commits into from
Dec 2, 2022

Conversation

AldoGl
Copy link
Contributor

@AldoGl AldoGl commented Nov 30, 2022

This PR adds the CORS sampler to Black-it.

Reference to the CORS sampler:
Regis, Rommel G., and Christine A. Shoemaker. "Constrained global optimization of expensive black box functions using radial basis functions." Journal of Global optimization 31.1 (2005): 153-171.

The PR also changes the name of black-it.utils.assert_ to black-it.utils._assert

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2022

Codecov Report

Merging #28 (5abb3c2) into main (fedece7) will decrease coverage by 8.03%.
The diff coverage is 41.37%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
- Coverage   97.72%   89.68%   -8.04%     
==========================================
  Files          23       25       +2     
  Lines        1231     1416     +185     
==========================================
+ Hits         1203     1270      +67     
- Misses         28      146     +118     
Impacted Files Coverage Δ
black_it/search_space.py 100.00% <ø> (ø)
black_it/samplers/cors.py 21.64% <21.64%> (ø)
black_it/samplers/knysh_korkolis.py 43.24% <43.24%> (ø)
black_it/samplers/particle_swarm.py 92.22% <66.66%> (ø)
black_it/calibrator.py 97.48% <100.00%> (ø)
black_it/loss_functions/base.py 100.00% <100.00%> (ø)
black_it/loss_functions/fourier.py 100.00% <100.00%> (ø)
black_it/loss_functions/gsl_div.py 100.00% <100.00%> (ø)
black_it/samplers/best_batch.py 100.00% <100.00%> (ø)
black_it/samplers/random_forest.py 100.00% <100.00%> (ø)

@AldoGl AldoGl force-pushed the k-k_sampler branch 3 times, most recently from 432be3f to 5abb3c2 Compare December 1, 2022 12:44
@AldoGl AldoGl changed the title Add CORS and KK samplers Add CORS sampler Dec 2, 2022
@AldoGl AldoGl force-pushed the k-k_sampler branch 2 times, most recently from 805dec1 to aa92861 Compare December 2, 2022 14:21
lint: black and vulture on cors sampler


f
Copy link
Contributor

@marcofavoritobi marcofavoritobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AldoGl AldoGl merged commit f666b54 into main Dec 2, 2022
@AldoGl AldoGl deleted the k-k_sampler branch December 2, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants