Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tables to append to series_samp array #27

Merged
merged 3 commits into from
Nov 22, 2022
Merged

Conversation

AldoGl
Copy link
Contributor

@AldoGl AldoGl commented Nov 22, 2022

Proposed changes

Use the .h5 format to store and dynamically update the series_samp array. This PR gives a huge speedup in the update of large arrays during a calibration. Work by @marcofavorito

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2022

Codecov Report

Merging #27 (00eee4a) into main (2cba7c8) will increase coverage by 0.11%.
The diff coverage is 96.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   97.60%   97.72%   +0.11%     
==========================================
  Files          23       23              
  Lines        1213     1232      +19     
==========================================
+ Hits         1184     1204      +20     
+ Misses         29       28       -1     
Impacted Files Coverage Δ
black_it/calibrator.py 97.48% <50.00%> (+0.01%) ⬆️
black_it/samplers/gaussian_process.py 98.80% <100.00%> (+1.21%) ⬆️
black_it/utils/json_pandas_checkpointing.py 100.00% <100.00%> (ø)

@AldoGl AldoGl force-pushed the use_tables_in_series_samp branch from 00eee4a to 3c8b22e Compare November 22, 2022 12:53
@AldoGl
Copy link
Contributor Author

AldoGl commented Nov 22, 2022

I will merge this soon as this PR was reviewed already by me and Marco

@AldoGl AldoGl merged commit fedece7 into main Nov 22, 2022
@AldoGl AldoGl deleted the use_tables_in_series_samp branch November 22, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants