Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calibrator: add sim_length param to Calibrator constructor #25

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

AldoGl
Copy link
Contributor

@AldoGl AldoGl commented Nov 21, 2022

Proposed changes

I add a sim_length parameter to Calibrator constructor.

This is useful if one uses a loss that allows time series of different length to be compared, and wants the simulated time series to be of a specified length.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

@AldoGl AldoGl force-pushed the add_sim_length_param_to_calibrato branch from 7345093 to af0b3b7 Compare November 21, 2022 14:04
@AldoGl AldoGl merged commit ec3f62b into main Nov 21, 2022
@AldoGl AldoGl deleted the add_sim_length_param_to_calibrato branch December 5, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant