Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCS code with comments #20

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Conversation

mmartinoli87
Copy link
Contributor

@mmartinoli87 mmartinoli87 commented Oct 27, 2022

Proposed changes

Addition to the "Model Confidence Sets" scheme to Black-it

@AldoGl
Copy link
Contributor

AldoGl commented Oct 27, 2022

Thank you @mmartinoli87 for (re)opening the PR. Just for reference, this is a continuation of #19.

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2022

Codecov Report

Merging #20 (334f0dd) into main (3433555) will decrease coverage by 6.64%.
The diff coverage is 11.36%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
- Coverage   99.44%   92.80%   -6.65%     
==========================================
  Files          22       24       +2     
  Lines        1086     1264     +178     
==========================================
+ Hits         1080     1173      +93     
- Misses          6       91      +85     
Impacted Files Coverage Δ
black_it/model_confidence_sets.py 11.36% <11.36%> (ø)
black_it/samplers/particle_swarm.py 92.22% <0.00%> (ø)

@AldoGl
Copy link
Contributor

AldoGl commented Oct 27, 2022

Ok, @mmartinoli87 I have written a draft in Python of the MCS code. It would be great if you could add a few more line of comments to the R code, and specifically where I ask questions in this commit 9244d57.

The code seem to work already, but we are still thinking about the best way to integrate it within the Black-it pipeline. It might be useful to discuss this together, considering that we also want to integrate your recent article (https://scholar.google.it/citations?view_op=view_citation&hl=it&user=bJcPI-4AAAAJ&sortby=pubdate&citation_for_view=bJcPI-4AAAAJ:YsMSGLbcyi4C) which makes use MCS as a sub-tool.

@AldoGl AldoGl force-pushed the main branch 2 times, most recently from aa127cd to 034937d Compare November 21, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants