-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MCS code with comments #20
base: main
Are you sure you want to change the base?
Conversation
Thank you @mmartinoli87 for (re)opening the PR. Just for reference, this is a continuation of #19. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
==========================================
- Coverage 99.44% 92.80% -6.65%
==========================================
Files 22 24 +2
Lines 1086 1264 +178
==========================================
+ Hits 1080 1173 +93
- Misses 6 91 +85
|
Ok, @mmartinoli87 I have written a draft in Python of the MCS code. It would be great if you could add a few more line of comments to the R code, and specifically where I ask questions in this commit 9244d57. The code seem to work already, but we are still thinking about the best way to integrate it within the Black-it pipeline. It might be useful to discuss this together, considering that we also want to integrate your recent article (https://scholar.google.it/citations?view_op=view_citation&hl=it&user=bJcPI-4AAAAJ&sortby=pubdate&citation_for_view=bJcPI-4AAAAJ:YsMSGLbcyi4C) which makes use MCS as a sub-tool. |
aa127cd
to
034937d
Compare
Proposed changes
Addition to the "Model Confidence Sets" scheme to Black-it