Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update poetry.lock #18

Merged
merged 7 commits into from
Oct 7, 2022
Merged

Update poetry.lock #18

merged 7 commits into from
Oct 7, 2022

Conversation

marcofavoritobi
Copy link
Contributor

Proposed changes

This PR updates the poetry.lock file using the command poetry update.

Fixes

n/a

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Further comments

n/a

There was a mismatch between the dependency versions installed by the test envirnoments
(specified by tox.ini) and the production/development environment (specified
by pyproject.toml).

For example:
- in pyproject.toml, pytest's version specifier was >=7.1.2,<7.2.0, but
  in tox.ini it was pytest>=6.2.5,<6.3.0
- in pyproject.toml, numpy's version specifier was ^1.22.3 (which installed 1.23.3), but
  in tox.ini it was numpy>=1.21.0,<1.22.0

These changes might have introduced errors in tests and/or linting checks,
which will be fixed in the following commits (but keeping the changes separated
for better clarity).
Fix mypy errors raised after the upgrade to numpy 1.23.3, which became
stricter in the checking of the type of elements of the NDArray generic.
- fix new error "consider-using-generator"
- add 'pylint.extensions.no_self_use' in load-plugins option due to changes in pylint 2.14
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2022

Codecov Report

Merging #18 (c07b097) into main (8221916) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head c07b097 differs from pull request most recent head 027ae63. Consider uploading reports for the commit 027ae63 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
- Coverage   99.46%   99.44%   -0.02%     
==========================================
  Files          25       22       -3     
  Lines        1116     1086      -30     
==========================================
- Hits         1110     1080      -30     
  Misses          6        6              
Impacted Files Coverage Δ
black_it/loss_functions/gsl_div.py 100.00% <100.00%> (ø)
black_it/plot/plot_results.py 100.00% <100.00%> (ø)
black_it/samplers/random_forest.py 100.00% <100.00%> (ø)
black_it/utils/__init__.py
black_it/__init__.py
black_it/utils/base.py

@@ -57,21 +57,23 @@ hypothesis = "^6.46.5"
ipython = "^8.3.0"
isort = "^5.10.1"
jupyter = "^1.0.0"
Markdown = "^3.3.7"
markdown-include = "^0.6.0"
Markdown = "==3.3.7"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs dependencies have been pinned to exact versions since, as it often happened in the past, the "docs stack" is fragile wrt version updates.

@muxator
Copy link

muxator commented Oct 7, 2022

LGTM.

  • the intermediate commits expose slight pre-existing problems that are then fixed later in the series. In this case this is a good strategy, since the history does a very good job of explaining where the problems laid;
  • the lockfile has been regenerated with Poetry 1.2.1. pyproject.toml does not use any 1.1-specific features, and thus the lockfile is compatible with older Poetry versions. Tested an installation with 1.1.15 and it works well;
  • replicated locally the test suite, lint and static checks, and all looks good.

Merging, thanks.

@muxator muxator merged commit 3433555 into main Oct 7, 2022
@muxator muxator deleted the update-poetry-lock branch October 7, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants