Simplification of CIs #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… files in lint the removal is needed to allow the same CIs to work both for pull requests and for merges on the main branch
Comment on lines
+16
to
+17
| os: [ubuntu-latest] | ||
| python-version: [3.8] |
There was a problem hiding this comment.
we could consider to test also against other Python version, e.g. 3.9 and 3.10, or other platforms, windows and macos.
There was a problem hiding this comment.
Ok that's a good point. I suggest we add 3.9 and 3.10 for the unit tests only and keep only 3.8 for lint and docs to keep overall CI time relatively short. For the same reason I would only test on ubuntu for the moment. What do you think?
AldoGl
force-pushed
the
fix_and_simplify_CIs
branch
from
824e9e3 to
979c7eb
Compare
AldoGl
force-pushed
the
fix_and_simplify_CIs
branch
from
979c7eb to
87a61ab
Compare
marcofavoritobi
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
I split the main.yml into lint.yml and test.yml, and remove the checks for changed files during linting.
The removal is needed to allow the same CIs to work both for pull requests and for merges on the main branch.
I also ignore the "safety" checks for ipywidgets, this will be needed util we update the package requirements with an ipywidgets version >= 8.0.0.