replace MethodOfMomentsLoss with MinkowskiLoss to see if the problem …

…arises from a different numerical accuracy of MethodOfMomentsLoss between MacOS and other platforms re-enable ubuntu to quickly see if one platform fails and another works (I expect that both are passing now).
bancaditalia · Sep 6, 2024 · 65d3dfe · 65d3dfe
1 parent 054b844
commit 65d3dfe
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -13,7 +13,7 @@ jobs:
 
     strategy:
       matrix:
-        os: [macos-latest]
+        os: [ubuntu-latest, macos-latest]
         python-version: ["3.12"]
 
     timeout-minutes: 30

diff --git a/examples/main.py b/examples/main.py
@@ -23,7 +23,7 @@
 import models.simple_models as md
 
 from black_it.calibrator import Calibrator
-from black_it.loss_functions.msm import MethodOfMomentsLoss
+from black_it.loss_functions.minkowski import MinkowskiLoss
 from black_it.samplers.best_batch import BestBatchSampler
 from black_it.samplers.halton import HaltonSampler
 from black_it.samplers.random_forest import RandomForestSampler
@@ -53,7 +53,7 @@
     print("Real data:", real_data)
 
     # define a loss
-    loss = MethodOfMomentsLoss()
+    loss = MinkowskiLoss()
 
     # define the calibration seed
     calibration_seed = 1

diff --git a/tests/test_examples/test_main.py b/tests/test_examples/test_main.py
@@ -24,7 +24,7 @@
 
 
 TRUE_PARAMETERS_STR = "True parameters:       [0.2, 0.2, 0.75]"
-BEST_PARAMETERS_STR = "Best parameters found: [0.19 0.21 0.68]"
+BEST_PARAMETERS_STR = "Best parameters found: [0.11 0.13 0.87]"
 
 
 class TestMainExample(BaseMainExampleTestClass):