feat: add integration workflow #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice! could you also check why lint failed? when I run my golangci-lint version |
|
I am able to reproduce the same err msg on my end. My lint version is |
|
ah ok. can u try to downgrade the version on CI? the goal is we want to avoid modifying OP's code as much as possible |
bournezjc
force-pushed
the
bourne/add_integration_workflow
branch
from
41a4ae5 to
0c27127
Compare
|
Downgraded to v1.59.1, looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new integration workflow, triggered by either push, pull request or workflow dispatch.
Test Plan
check Actions on github repository
