fix: BTCDelgationResponse missing staking_time
#197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitferry
requested review from
Lazar955 and
RafilxTenfen
and removed request for
a team
gitferry
added
bug
gitferry
requested review from
KonradStaniec
and removed request for
Lazar955 and
RafilxTenfen
gitferry
changed the title
BTCDelgationResponse missing staking_time
KonradStaniec
approved these changes
Oct 15, 2024
samricotta
approved these changes
Oct 15, 2024
|
This will need a new release at btc-staker, because it broke the proto for query |
Yep, this will go to the next devnet release as backporting to v0.12.x causes a lot of conflicts due to block height type change |
maurolacy
reviewed
Oct 25, 2024
| @@ -251,40 +251,42 @@ message BTCDelegationResponse { | |||
| // fp_btc_pk_list is the list of BIP-340 PKs of the finality providers that | |||
| // this BTC delegation delegates to | |||
| repeated bytes fp_btc_pk_list = 3 [ (gogoproto.customtype) = "github.com/babylonlabs-io/babylon/types.BIP340PubKey" ]; | |||
| // staking_time is the number of blocks for which the delegation is locked on BTC chain | |||
| uint32 staking_time = 4; | |||
There was a problem hiding this comment.
Nit: To try to be more backwards compatible, you can use a new label here, i.e.:
uint32 staking_time = 17;
That way the older versions will be able to handle all the other fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pre-approval flow, the delegation has zero value for both
startHeightandendHeight. Therefore, the staking time should not be inferred fromendHeight - startHeight. Instead, it should be stored seprately. This PR addsstakingTimetoBTCDelegationResponse