Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Handle FinalityProviderSigningInfo object #194

Merged
merged 7 commits into from
Oct 15, 2024
Merged

Conversation

samricotta
Copy link
Contributor

@samricotta samricotta commented Oct 14, 2024

Summary

Part closes: https://github.com/babylonlabs-io/pm/issues/72

Currently some of the objects in the babylon apis are exposed and need to be handled correctly seen in here

This PR handles the FinalityProviderSigningInfo in https://github.com/babylonlabs-io/babylon/blob/v0.11.0/x/finality/keeper/grpc_query.go#L230

@samricotta samricotta marked this pull request as ready for review October 14, 2024 15:16
@samricotta samricotta requested a review from a team as a code owner October 14, 2024 15:16
@samricotta samricotta requested review from KonradStaniec and RafilxTenfen and removed request for a team October 14, 2024 15:16
Copy link
Contributor

@RafilxTenfen RafilxTenfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only one suggestion

Copy link
Collaborator

@KonradStaniec KonradStaniec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments in general lgtm!

CHANGELOG.md Outdated Show resolved Hide resolved
proto/babylon/finality/v1/query.proto Show resolved Hide resolved
x/finality/keeper/grpc_query.go Outdated Show resolved Hide resolved
@samricotta samricotta merged commit c6167e5 into main Oct 15, 2024
20 checks passed
samricotta added a commit that referenced this pull request Oct 15, 2024
## Summary

Part closes: babylonlabs-io/pm#72

Currently some of the objects in the babylon apis are exposed and need
to be handled correctly seen in
[here](babylonlabs-io/pm#72)

This PR handles the `FinalityProviderSigningInfo` in
https://github.com/babylonlabs-io/babylon/blob/v0.11.0/x/finality/keeper/grpc_query.go#L230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants