chore: Bitcoin heights and depths made uint32 #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitsalis
requested review from
RafilxTenfen and
gitferry
and removed request for
a team
KonradStaniec
added
the
consensus breaking
Lazar955
approved these changes
Oct 11, 2024
gitferry
approved these changes
Oct 11, 2024
vitsalis
force-pushed
the
btc-heights-uint32
branch
from
e67f0fc to
54c0d33
Compare
yep, I expect this can be handled when auxiliary programs are updated to the latest Babylon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #179
This is an impactful change that brings the BTC height types that we use more in sync with the expected types for BTC block heights, similar to those that are used by other libraries. It is part of the code improvement efforts that we are doing in preparation of the next testnet.
Given that it touches many files, I believe that this change should happen sooner than later so that it can be appropriately tested.