chore: upgrade token distribution #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure it rebuilds and do not use the cached one
RafilxTenfen
requested review from
gitferry and
KonradStaniec
and removed request for
a team
|
|
||
| amount := sdk.NewCoin(appparams.BaseCoinUnit, sdkmath.NewInt(td.Amount)) | ||
| if err := bankK.SendCoins(ctx, sender, receiver, sdk.NewCoins(amount)); err != nil { | ||
| return err |
There was a problem hiding this comment.
Just few quesation for better understanding:
- what happens if this returns and error ? does upgrade stop ?
- I imagine
bankK.SendCoinsdoes all necessary validation if sender have enough coins etc?
I am just thinking of the scenario if by mistake we have some invalid account as sender and what will happen then. I imagine upgrade will happen on chain which is priavate yet and it will fails, so we will be able easily to re-do it.
There was a problem hiding this comment.
yes, if it fails it is going to panic and stop the upgrade
The upgrade is called during PreBlocker I expect that the context is handled with commit and rollback in case of failures, but in our case, since it is all private we will be able to run it again
…upgrade-token-distribution
KonradStaniec
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{ "token_distribution": [ { "address_sender": "bbn14d97wthm9fqvvdd96ax8lnfppwknndxztevs7k", "address_receiver": "bbn13t5cnqj6t0p4xa40cwhmgv4wju0zl6g8slk8rz", "amount": 100000 }, ... ] }type PreUpgradeFunc func([]*chain.Config)