Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consumer chain finality provider #276

Merged
merged 4 commits into from
Mar 25, 2024
Merged

Consumer chain finality provider #276

merged 4 commits into from
Mar 25, 2024

Conversation

maurolacy
Copy link
Contributor

Based on / same as #275.

@maurolacy maurolacy changed the base branch from dev to base/consumer-chain-support March 22, 2024 16:20
@maurolacy maurolacy marked this pull request as ready for review March 22, 2024 16:20
SebastianElvis
SebastianElvis approved these changes Mar 24, 2024
View reviewed changes
Copy link
Member

@SebastianElvis SebastianElvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably it's good to add an e2e test (under itest/) to ensure registering a consumer chain FP works properly, but not a blocker for now 👍

@SebastianElvis SebastianElvis mentioned this pull request Mar 24, 2024
Closed
@maurolacy
Copy link
Contributor Author

Probably it's good to add an e2e test (under itest/) to ensure registering a consumer chain FP works properly, but not a blocker for now 👍

Can do in a follow-up.

@maurolacy maurolacy merged commit a7b6cc8 into base/consumer-chain-support Mar 25, 2024
2 checks passed
@maurolacy maurolacy deleted the f/consumer-finality-provider branch March 25, 2024 06:32
gusin13 pushed a commit that referenced this pull request May 16, 2024
@maurolacy @gusin13
Consumer chain finality provider (#276)
d94e071 
* Init
* Update babylon-private reference
* Revert "CI: Remove redundant SSH key logic (#218)"
gusin13 pushed a commit that referenced this pull request May 17, 2024
@maurolacy @gusin13
Consumer chain finality provider (#276)
95ecc63 
* Init
* Update babylon-private reference
* Revert "CI: Remove redundant SSH key logic (#218)"
gusin13 pushed a commit that referenced this pull request May 21, 2024
@maurolacy @gusin13
Consumer chain finality provider (#276)
db7cf8a 
* Init
* Update babylon-private reference
* Revert "CI: Remove redundant SSH key logic (#218)"
@maurolacy maurolacy mentioned this pull request May 22, 2024
Closed
SebastianElvis pushed a commit that referenced this pull request Jun 5, 2024
@maurolacy @SebastianElvis
Consumer chain finality provider (#276)
b79ac31 
* Init
* Update babylon-private reference
* Revert "CI: Remove redundant SSH key logic (#218)"
maurolacy added a commit that referenced this pull request Jul 5, 2024
@maurolacy
Consumer chain finality provider (#276)
445602a 
* Init
* Update babylon-private reference
* Revert "CI: Remove redundant SSH key logic (#218)"
gusin13 pushed a commit that referenced this pull request Jul 9, 2024
@maurolacy @gusin13
Consumer chain finality provider (#276)
a26483d 
* Init
* Update babylon-private reference
* Revert "CI: Remove redundant SSH key logic (#218)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastianElvis SebastianElvis SebastianElvis approved these changes

@gitferry gitferry gitferry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maurolacy @gitferry @SebastianElvis