Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add params for preset-typescript #1978

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

tsangint
Copy link

@tsangint tsangint commented Mar 3, 2019

In the node api preset-typescript needs to set the allExtension parameter, otherwise babel-core determines that there is a test field, subsequent detection will throw an error

error

Related code:

https://github.com/babel/babel/blob/master/packages/babel-preset-typescript/src/index.js#L30
https://github.com/babel/babel/blob/master/packages/babel-core/src/config/config-chain.js#L605

@babel-bot
Copy link
Contributor

babel-bot commented Mar 3, 2019

Deploy preview for babel ready!

Built with commit c24caa9

https://deploy-preview-1978--babel.netlify.com

@nicolo-ribaudo
Copy link
Member

I'd prefer to pass something like filename: "example.ts" and document that it needs a filename or the allExtension a option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants