Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove JSXNamespacedName from valid CallExpression args #16421

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Remove JSXNamespacedName from valid CallExpression args #16421

merged 1 commit into from
Apr 12, 2024

Conversation

nicolo-ribaudo
Copy link
Member

Q                       A
Fixed Issues? Fixes #16420
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

JSXNamespacedName is used for namespaced XML properties in things like <div namespace:name="value">, but fn(namespace:name) doesn't make any sense.

@nicolo-ribaudo nicolo-ribaudo added the PR: Internal 🏠 A type of pull request used for our changelog categories label Apr 8, 2024
@babel-bot
Copy link
Collaborator

babel-bot commented Apr 8, 2024 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56710

@nicolo-ribaudo nicolo-ribaudo force-pushed the classexpr-remove-jsx-namespaced branch from c565c29 to 063c02f Compare April 8, 2024 12:28
@nicolo-ribaudo nicolo-ribaudo merged commit 33d8d7d into babel:main Apr 12, 2024
50 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the classexpr-remove-jsx-namespaced branch April 12, 2024 10:57
@davidbilling davidbilling mentioned this pull request May 20, 2024
Merged
@bee22193 bee22193 mentioned this pull request May 20, 2024
Open
This was referenced May 20, 2024
Open
Open
Open
@basharat-j basharat-j mentioned this pull request May 20, 2024
Open
@ashly1111111 ashly1111111 mentioned this pull request May 20, 2024
Open
@scudette scudette mentioned this pull request May 20, 2024
Closed
@AnushaSalian AnushaSalian mentioned this pull request May 20, 2024
Open
@nejidevelops nejidevelops mentioned this pull request May 20, 2024
Open
@MelvinBot MelvinBot mentioned this pull request May 20, 2024
Closed
@davidbilling davidbilling mentioned this pull request May 20, 2024
Merged
@anandgupta193 anandgupta193 mentioned this pull request May 20, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request May 20, 2024
Open
@nejidevelops nejidevelops mentioned this pull request May 20, 2024
Open
@GhassenEljday GhassenEljday mentioned this pull request May 20, 2024
Closed
This was referenced May 20, 2024
Open
Open
@mdfkbtc mdfkbtc mentioned this pull request May 21, 2024
Open
@NOUIY NOUIY mentioned this pull request May 21, 2024
Open
@satkunas satkunas mentioned this pull request May 21, 2024
Merged
@tiff-es tiff-es mentioned this pull request May 21, 2024
Open
@anandgupta193 anandgupta193 mentioned this pull request Jul 11, 2024
Open
@NOUIY NOUIY mentioned this pull request Jul 11, 2024
Open
This was referenced Jul 11, 2024
Open
Open
This was referenced Jul 11, 2024
Open
Open
Open
Open
@Mhmonicox Mhmonicox mentioned this pull request Jul 11, 2024
Open
@tahabiyikli tahabiyikli mentioned this pull request Jul 12, 2024
Open
@anandgupta193 anandgupta193 mentioned this pull request Jul 12, 2024
Open
@mdfkbtc mdfkbtc mentioned this pull request Jul 12, 2024
Open
@ashly1111111 ashly1111111 mentioned this pull request Jul 12, 2024
Open
@abhisheksurpur abhisheksurpur mentioned this pull request Jul 12, 2024
Open
This was referenced Jul 12, 2024
Open
Open
@NOUIY NOUIY mentioned this pull request Jul 12, 2024
Open
This was referenced Jul 12, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@bee22193 bee22193 mentioned this pull request Jul 13, 2024
Open
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 13, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liuxingbaoyu liuxingbaoyu liuxingbaoyu approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: types PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CallExpression should not accept JSXNamespacedName as an argument
3 participants
@nicolo-ribaudo @babel-bot @liuxingbaoyu