Updates to dub.json for windows build support, README tweaks for newbs #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g, update docs Docs need to include a few details about building and testing.
|
I will set tests on Debian 9, and after in a virtual machine running Ubuntu and Mint. |
|
@pedroalvesbatista yeah, if you can double check my changes and make sure that you can get the dub build and dub test working without errors, that would be cool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a few things to make this a smoother landing for someone using this on Windows. Dub should be capable of handling a cross platform support without the downstream user needing to modify the dub.json. The head scratcher for me was that the windows default rocksdb build produces a rocksdb-shared.dll (not rocksdb.dll). So the existing dub.json won't work out of the box. I have not tested on linux.