fix gateway dockerfile to use apt and libc6 #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loicknuchel
reviewed
Dec 5, 2023
| @@ -1,6 +1,6 @@ | |||
| FROM node:18-slim AS deps | |||
| # Check https://github.com/nodejs/docker-node/tree/b4117f9333da4138b03a546ec926ef50a31506c3#nodealpine to understand why libc6-compat might be needed. | |||
| RUN apk add --no-cache libc6-compat | |||
| RUN apt install libc6 | |||
There was a problem hiding this comment.
Thanks for the PR 👍
Still given the comment above, still not very confident it won't break anything...
Do you know the difference between libc6 and libc6-compat?
There was a problem hiding this comment.
I don't think, it will break something because libc6-compat is only set of lib compatible with glib since alpine use musl no?
loicknuchel
force-pushed
the
main
branch
4 times, most recently
from
84388be to
9929ba9
Compare
|
Do we still need to let this PR open? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.