refactor(axelarnet)!: remove CallContract message type #2215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haiyizxx
force-pushed
the
AXE-4183-Remove-axelarnet-module-CallContract-sdk-Msg
branch
from
ca8b196 to
d79a9df
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2215 +/- ##
==========================================
- Coverage 39.38% 39.35% -0.04%
==========================================
Files 375 375
Lines 37417 37293 -124
==========================================
- Hits 14738 14677 -61
+ Misses 21730 21673 -57
+ Partials 949 943 -6 ☔ View full report in Codecov by Sentry. |
cgorenflo
approved these changes
Dec 19, 2024
cjcobb23
reviewed
Dec 19, 2024
| @@ -173,6 +173,7 @@ message RouteMessageRequest { | |||
| message RouteMessageResponse {} | |||
|
|
|||
| message CallContractRequest { | |||
| option deprecated = true; | |||
There was a problem hiding this comment.
why can't we just remove the type from here?
| @@ -32,6 +32,7 @@ func RegisterLegacyMsgInterfaces(registry cdctypes.InterfaceRegistry) { | |||
|
|
|||
| r.RegisterCustomTypeURL((*sdk.Msg)(nil), "/axelar.evm.v1beta1.CreateTransferOwnershipRequest", &evmtypes.CreateTransferOwnershipRequest{}) | |||
| r.RegisterCustomTypeURL((*sdk.Msg)(nil), "/axelar.axelarnet.v1beta1.RegisterIBCPathRequest", &axelarnettypes.RegisterIBCPathRequest{}) | |||
| r.RegisterCustomTypeURL((*sdk.Msg)(nil), "/axelar.axelarnet.v1beta1.CallContractRequest", &axelarnettypes.CallContractRequest{}) | |||
There was a problem hiding this comment.
why do we need to add this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Todos
Steps to Test
Expected Behaviour
Other Notes