Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: bump go to 1.23 #2179

Merged
merged 16 commits into from
Sep 26, 2024
Merged

chore!: bump go to 1.23 #2179

merged 16 commits into from
Sep 26, 2024

Conversation

milapsheth
Copy link
Member

@milapsheth milapsheth commented Sep 5, 2024

Description

AXE-4761

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues
  • Tag type of change
  • Upgrade handler

Steps to Test

Expected Behaviour

Other Notes

@milapsheth milapsheth requested a review from a team as a code owner September 5, 2024 16:38
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes missing coverage. Please review.

Project coverage is 39.83%. Comparing base (2c52c94) to head (f25456f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
vald/multisig/mgr.go 0.00% 3 Missing ⚠️
testutils/fake/interfaces/mock/store.go 0.00% 2 Missing ⚠️
x/ante/undelegate.go 0.00% 2 Missing ⚠️
vald/sign.go 0.00% 1 Missing ⚠️
x/ante/check_proxy.go 0.00% 1 Missing ⚠️
x/ante/check_refund.go 0.00% 1 Missing ⚠️
x/axelarnet/types/types.go 0.00% 1 Missing ⚠️
x/multisig/exported/mock/types.go 0.00% 1 Missing ⚠️
x/nexus/keeper/grpc_query.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2179      +/-   ##
==========================================
- Coverage   49.42%   39.83%   -9.60%     
==========================================
  Files         272      373     +101     
  Lines       16151    30855   +14704     
==========================================
+ Hits         7983    12290    +4307     
- Misses       7557    17640   +10083     
- Partials      611      925     +314     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@milapsheth milapsheth marked this pull request as draft September 23, 2024 17:25
@milapsheth
Copy link
Member Author

Investigating docker image build failure with newer alpine version, marked as draft until resolved

@milapsheth milapsheth marked this pull request as ready for review September 26, 2024 20:40
@milapsheth milapsheth merged commit 29bb3e9 into main Sep 26, 2024
8 of 10 checks passed
@milapsheth milapsheth deleted the chore/go-version branch September 26, 2024 20:42
@milapsheth milapsheth restored the chore/go-version branch September 26, 2024 20:46
@milapsheth milapsheth deleted the chore/go-version branch September 26, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants