Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tss): remove key id check to reduce heartbeat gas costs #2173

Merged
merged 5 commits into from
Aug 21, 2024

Conversation

cgorenflo
Copy link
Contributor

Testing all keys in the HeartBeat event costs a lot of gas and has no added benefit, since the key is generated by tofnd on the fly anyway. After this change vald will no longer add key IDs to the event response. Because it is not consensus-breaking, we can roll out this patch without a network upgrade. With the next release we will then remove the key IDs completely from the event

@cgorenflo cgorenflo requested a review from a team as a code owner August 20, 2024 19:46
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 49.52%. Comparing base (715b5e4) to head (d364427).
Report is 1 commits behind head on main.

Files Patch % Lines
vald/tss/tss.go 0.00% 4 Missing ⚠️
x/tss/types/msg_ack.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2173      +/-   ##
==========================================
+ Coverage   49.43%   49.52%   +0.08%     
==========================================
  Files         269      269              
  Lines       16131    16098      -33     
==========================================
- Hits         7974     7972       -2     
+ Misses       7545     7514      -31     
  Partials      612      612              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

x/tss/types/msg_ack.go Outdated Show resolved Hide resolved
proto/axelar/tss/v1beta1/tx.proto Outdated Show resolved Hide resolved
proto/axelar/tss/v1beta1/tx.proto Show resolved Hide resolved
@cgorenflo cgorenflo merged commit fa154e3 into main Aug 21, 2024
7 of 9 checks passed
@cgorenflo cgorenflo deleted the reduce-heartbeat-gas-cost branch August 21, 2024 15:02
cgorenflo added a commit that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants