-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait for CreateMPU before returning from put_object #1192
Open
passaro
wants to merge
3
commits into
awslabs:main
Choose a base branch
from
passaro:async-put-object
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
passaro
requested a deployment
to
PR integration tests
December 9, 2024 13:48 — with
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
December 9, 2024 13:48 — with
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
December 9, 2024 13:48 — with
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
December 9, 2024 13:48 — with
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
December 9, 2024 13:48 — with
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
December 9, 2024 13:48 — with
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
December 9, 2024 13:48 — with
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
December 9, 2024 13:53 — with
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
December 9, 2024 13:53 — with
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
December 9, 2024 13:53 — with
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
December 9, 2024 13:53 — with
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
December 9, 2024 13:53 — with
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
December 9, 2024 13:53 — with
GitHub Actions
Waiting
passaro
requested a deployment
to
PR integration tests
December 9, 2024 13:53 — with
GitHub Actions
Waiting
passaro
force-pushed
the
async-put-object
branch
from
December 10, 2024 10:46
f204ee9
to
07b850d
Compare
passaro
temporarily deployed
to
PR integration tests
December 10, 2024 10:46 — with
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
December 10, 2024 10:46 — with
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
December 10, 2024 10:46 — with
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
December 10, 2024 10:46 — with
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
December 10, 2024 10:46 — with
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
December 10, 2024 10:46 — with
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
December 10, 2024 10:46 — with
GitHub Actions
Inactive
Signed-off-by: Alessandro Passaro <[email protected]>
Signed-off-by: Alessandro Passaro <[email protected]>
Signed-off-by: Alessandro Passaro <[email protected]>
passaro
force-pushed
the
async-put-object
branch
from
December 12, 2024 08:17
07b850d
to
f9748e2
Compare
passaro
temporarily deployed
to
PR integration tests
December 12, 2024 08:17 — with
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
December 12, 2024 08:17 — with
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
December 12, 2024 08:17 — with
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
December 12, 2024 08:17 — with
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
December 12, 2024 08:17 — with
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
December 12, 2024 08:17 — with
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR integration tests
December 12, 2024 08:17 — with
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR benchmarks
December 12, 2024 08:17 — with
GitHub Actions
Inactive
passaro
had a problem deploying
to
PR benchmarks
December 12, 2024 08:17 — with
GitHub Actions
Failure
passaro
temporarily deployed
to
PR benchmarks
December 12, 2024 08:17 — with
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR benchmarks
December 12, 2024 08:17 — with
GitHub Actions
Inactive
passaro
temporarily deployed
to
PR benchmarks
December 12, 2024 08:17 — with
GitHub Actions
Inactive
monthonk
previously approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, nice that we can maintain the same behavior for open
.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3CrtClient::put_object
was originally implemented so that it would complete immediately and return aPutObjectRequest
implementation. Any error from the S3 request would only be returned on callingwrite
orcomplete
on thePutObjectRequest
. With this change, we modifyput_object
to await for the initialCreateMultipartUpload
request to complete and only then either return aPutObjectRequest
or propagate the error from the request. This is analogous to what done forget_object
in #1171 and addresses an issue where errors were not propagated correctly (#1007).At the file handle level, however, we still want the
open
operation to complete quickly, without waiting forCreateMultipartUpload
to complete. In order to preserve the previous behavior,upload::atomic
was adapted to spawn a concurrent task in the background when callingput_object
.Does this change impact existing behavior?
Yes.
Does this change need a changelog entry?
Yes, for
mountpoint-s3-client
. No user-visible changes inmountpoint-s3
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).