Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for CreateMPU before returning from put_object #1192

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

passaro
Copy link
Contributor

@passaro passaro commented Dec 9, 2024

S3CrtClient::put_object was originally implemented so that it would complete immediately and return a PutObjectRequest implementation. Any error from the S3 request would only be returned on calling write or complete on the PutObjectRequest. With this change, we modify put_object to await for the initial CreateMultipartUpload request to complete and only then either return a PutObjectRequest or propagate the error from the request. This is analogous to what done for get_object in #1171 and addresses an issue where errors were not propagated correctly (#1007).

At the file handle level, however, we still want the open operation to complete quickly, without waiting for CreateMultipartUpload to complete. In order to preserve the previous behavior, upload::atomic was adapted to spawn a concurrent task in the background when calling put_object.

Does this change impact existing behavior?

Yes.

Does this change need a changelog entry?

Yes, for mountpoint-s3-client. No user-visible changes in mountpoint-s3.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

@passaro passaro requested a deployment to PR integration tests December 9, 2024 13:48 — with GitHub Actions Waiting
@passaro passaro requested a deployment to PR integration tests December 9, 2024 13:48 — with GitHub Actions Waiting
@passaro passaro requested a deployment to PR integration tests December 9, 2024 13:48 — with GitHub Actions Waiting
@passaro passaro requested a deployment to PR integration tests December 9, 2024 13:48 — with GitHub Actions Waiting
@passaro passaro requested a deployment to PR integration tests December 9, 2024 13:48 — with GitHub Actions Waiting
@passaro passaro requested a deployment to PR integration tests December 9, 2024 13:48 — with GitHub Actions Waiting
@passaro passaro requested a deployment to PR integration tests December 9, 2024 13:48 — with GitHub Actions Waiting
@passaro passaro requested a deployment to PR integration tests December 9, 2024 13:53 — with GitHub Actions Waiting
@passaro passaro requested a deployment to PR integration tests December 9, 2024 13:53 — with GitHub Actions Waiting
@passaro passaro requested a deployment to PR integration tests December 9, 2024 13:53 — with GitHub Actions Waiting
@passaro passaro requested a deployment to PR integration tests December 9, 2024 13:53 — with GitHub Actions Waiting
@passaro passaro requested a deployment to PR integration tests December 9, 2024 13:53 — with GitHub Actions Waiting
@passaro passaro requested a deployment to PR integration tests December 9, 2024 13:53 — with GitHub Actions Waiting
@passaro passaro requested a deployment to PR integration tests December 9, 2024 13:53 — with GitHub Actions Waiting
@passaro passaro temporarily deployed to PR integration tests December 10, 2024 10:46 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests December 10, 2024 10:46 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests December 10, 2024 10:46 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests December 10, 2024 10:46 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests December 10, 2024 10:46 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests December 10, 2024 10:46 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests December 10, 2024 10:46 — with GitHub Actions Inactive
@passaro passaro marked this pull request as ready for review December 10, 2024 11:23
Signed-off-by: Alessandro Passaro <[email protected]>
Signed-off-by: Alessandro Passaro <[email protected]>
Signed-off-by: Alessandro Passaro <[email protected]>
@passaro passaro temporarily deployed to PR integration tests December 12, 2024 08:17 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests December 12, 2024 08:17 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests December 12, 2024 08:17 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests December 12, 2024 08:17 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests December 12, 2024 08:17 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests December 12, 2024 08:17 — with GitHub Actions Inactive
@passaro passaro temporarily deployed to PR integration tests December 12, 2024 08:17 — with GitHub Actions Inactive
@passaro passaro added the performance PRs to run benchmarks on label Dec 12, 2024
@passaro passaro deployed to PR benchmarks December 12, 2024 14:25 — with GitHub Actions Active
monthonk
monthonk previously approved these changes Dec 12, 2024
Copy link
Contributor

@monthonk monthonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice that we can maintain the same behavior for open.

@passaro passaro added this pull request to the merge queue Dec 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 13, 2024
@monthonk monthonk dismissed their stale review December 13, 2024 14:55

need to look at the failing test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance PRs to run benchmarks on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants