Skip to content
This repository has been archived by the owner on Oct 17, 2024. It is now read-only.

Fixed go module versioning (v2 major) #232

Merged
merged 2 commits into from
Oct 26, 2019

Conversation

PaulMaddox
Copy link
Contributor

Issue #, if availble: Fixes #229, #206

Description of changes:
When v2 was released, the go.mod file & import structure should have been updated.
See: https://medium.com/@elliotchance/major-versions-in-go-modules-explained-ec7c1df3888b
Thanks for the heads up on this @paxan

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@PaulMaddox PaulMaddox merged commit 701dcff into awslabs:master Oct 26, 2019
@paxan
Copy link

paxan commented Oct 26, 2019

It seems weird that go.mod now has this line:

github.com/awslabs/goformation v1.4.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't require v2.3.0 because go.mod does not comply with Go Modules semver rules
2 participants