Request response workspace #843
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfod
approved these changes
Nov 18, 2024
src/main/java/software/amazon/awssdk/crt/iot/MqttRequestResponseClient.java
Show resolved
Hide resolved
src/main/java/software/amazon/awssdk/crt/iot/MqttRequestResponseClientBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/software/amazon/awssdk/crt/iot/MqttRequestResponseClientBuilder.java
Outdated
Show resolved
Hide resolved
| (void)jni_class; | ||
| aws_cache_jni_ids(env); | ||
|
|
||
| if (max_request_response_subscriptions < 0 || max_streaming_subscriptions < 0 || operation_timeout_seconds < 0) { |
There was a problem hiding this comment.
Shouldn't it be max_request_response_subscriptions < 2? Also, a followup question: why duplicate this check here if aws-c-mqtt already validates it?
https://github.com/awslabs/aws-c-mqtt/blob/main/source/request-response/subscription_manager.c#L787
There was a problem hiding this comment.
It's debatable: a creation failure requires log analysis to determine why, but with this redundant check the problem is embedded into the exception message.
There was a problem hiding this comment.
Yeah, I see how it might benefit users. Let's keep it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial request response client create/destroy APIs/tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.