Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the stream arn parameter when the next token is present #482

Merged
merged 2 commits into from
Feb 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
## Changelog
### 0.15.5
* [#482](https://github.com/awslabs/amazon-kinesis-producer/pull/482) Remove the stream arn parameter when the next token is present

### 0.15.4

Expand Down
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,9 @@ If you have further questions [please open a GitHub Issue](https://github.com/aw
This is a restatement of the [notice published](https://docs.aws.amazon.com/streams/latest/dev/kinesis-kpl-upgrades.html) in the [Amazon Kinesis Data Streams Developer Guide][kinesis-developer-guide]

## Release Notes
### 0.15.5
* [#482](https://github.com/awslabs/amazon-kinesis-producer/pull/482) Remove the stream arn parameter when the next token is present

### 0.15.4

### 0.15.3
Expand Down
2 changes: 1 addition & 1 deletion aws/kinesis/core/kinesis_producer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ struct EndpointConfiguration {
sts_endpoint_(sts_endpoint) {}
};

const constexpr char* kVersion = "0.14.13N";
const constexpr char* kVersion = "0.15.5N";
const std::unordered_map< std::string, EndpointConfiguration > kRegionEndpointOverride = {
{ "cn-north-1", { "kinesis.cn-north-1.amazonaws.com.cn", "monitoring.cn-north-1.amazonaws.com.cn" } },
{ "cn-northwest-1", { "kinesis.cn-northwest-1.amazonaws.com.cn", "monitoring.cn-northwest-1.amazonaws.com.cn" } }
Expand Down
1 change: 0 additions & 1 deletion aws/kinesis/core/shard_map.cc
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ void ShardMap::list_shards(const Aws::String& next_token) {

if (!next_token.empty()) {
req.SetNextToken(next_token);
if (!stream_arn_.empty()) req.SetStreamARN(stream_arn_);
} else {
req.SetStreamName(stream_);
if (!stream_arn_.empty()) req.SetStreamARN(stream_arn_);
Expand Down
2 changes: 1 addition & 1 deletion java/amazon-kinesis-producer-sample/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
<dependency>
<groupId>com.amazonaws</groupId>
<artifactId>amazon-kinesis-producer</artifactId>
<version>0.15.4</version>
<version>0.15.5</version>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
Expand Down
2 changes: 1 addition & 1 deletion java/amazon-kinesis-producer/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>com.amazonaws</groupId>
<artifactId>amazon-kinesis-producer</artifactId>
<version>0.15.4</version>
<version>0.15.5</version>
<name>Amazon Kinesis Producer Library</name>

<scm>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
public final class GlueSchemaRegistrySerializerInstance {

private volatile GlueSchemaRegistrySerializer instance = null;
private static final String USER_AGENT_APP_NAME = "kpl-0.15.4";
private static final String USER_AGENT_APP_NAME = "kpl-0.15.5";

/**
* Instantiate GlueSchemaRegistrySerializer using the KinesisProducerConfiguration.
Expand Down