Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(setup) Missing on_completion param for MavenJarDownloader #35

Merged
merged 2 commits into from
Nov 21, 2016

Conversation

spg
Copy link
Contributor

@spg spg commented Nov 18, 2016

This was causing:

(amazon-kinesis-client-python)➜  amazon-kinesis-client-python git:(master) ✗ python setup.py download_jars
running download_jars
Traceback (most recent call last):
  File "setup.py", line 253, in <module>
    zip_safe=False,
  File "/usr/local/Cellar/python/2.7.9/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/core.py", line 151, in setup
    dist.run_commands()
  File "/usr/local/Cellar/python/2.7.9/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/dist.py", line 953, in run_commands
    self.run_command(cmd)
  File "/usr/local/Cellar/python/2.7.9/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/dist.py", line 972, in run_command
    cmd_obj.run()
  File "setup.py", line 172, in run
    downloader = MavenJarDownloader()
TypeError: __init__() takes at least 2 arguments (1 given)

@pfifer
Copy link
Contributor

pfifer commented Nov 18, 2016

Thanks for catching this.

Please confirm that we can use, modify, copy, and redistribute this contribution.

Thanks.

@spg
Copy link
Contributor Author

spg commented Nov 18, 2016

@pfifer I confirm that you can use, modify, copy, and redistribute this contribution.

@pfifer pfifer merged commit 80aec61 into awslabs:master Nov 21, 2016
pfifer added a commit to pfifer/amazon-kinesis-client-python that referenced this pull request Nov 21, 2016
* PR awslabs#35: Downloading JAR files now runs correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants