Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add detailed type to AWS::Serverless::Api schema #2638

Merged
merged 5 commits into from
Nov 22, 2022
Merged

Add detailed type to AWS::Serverless::Api schema #2638

merged 5 commits into from
Nov 22, 2022

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented Nov 22, 2022

Issue #, if available

#1133

Description of changes

Description of how you validated changes

Checklist

  • Adheres to the development guidelines
  • Add/update unit tests using:
  • Add/update integration tests
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Do these changes include any template validations?
    • Did the newly validated properties support intrinsics prior to adding the validations? (If unsure, please review Intrinsic Functions before proceeding).
      • Does the pull request ensure that intrinsics remain functional with the new validations?

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@GavinZZ GavinZZ requested a review from a team as a code owner November 22, 2022 00:26
hoffa
hoffa approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@hoffa hoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@GavinZZ GavinZZ merged commit 63a70d8 into develop Nov 22, 2022
@hoffa hoffa deleted the api_schema branch November 22, 2022 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaythapa aaythapa aaythapa approved these changes

@hoffa hoffa hoffa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GavinZZ @hoffa @aaythapa