Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add detailed type to AWS::Serverless::Lambda Schema #2635

Merged
merged 5 commits into from
Nov 21, 2022
Merged

Add detailed type to AWS::Serverless::Lambda Schema #2635

merged 5 commits into from
Nov 21, 2022

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented Nov 21, 2022

Issue #, if available

#1133

Description of changes

Description of how you validated changes

Checklist

  • Adheres to the development guidelines
  • Add/update unit tests using:
  • Add/update integration tests
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Do these changes include any template validations?
    • Did the newly validated properties support intrinsics prior to adding the validations? (If unsure, please review Intrinsic Functions before proceeding).
      • Does the pull request ensure that intrinsics remain functional with the new validations?

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@GavinZZ GavinZZ requested a review from a team as a code owner November 21, 2022 22:48
@GavinZZ GavinZZ changed the title Add detaild type to AWS::Serverless::Lambda Schema Add detailed type to AWS::Serverless::Lambda Schema Nov 21, 2022
@GavinZZ GavinZZ enabled auto-merge (squash) November 21, 2022 23:18
@GavinZZ GavinZZ merged commit b86468f into develop Nov 21, 2022
@GavinZZ GavinZZ deleted the lambda_events_schema_2 branch November 23, 2022 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoffa hoffa hoffa approved these changes

@acristin acristin acristin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GavinZZ @acristin @hoffa