Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: ensure latest schema is always generated #2632

Merged
merged 1 commit into from
Nov 21, 2022
Merged

chore: ensure latest schema is always generated #2632

merged 1 commit into from
Nov 21, 2022

Conversation

hoffa
Copy link
Contributor

@hoffa hoffa commented Nov 21, 2022 •
edited
Loading

Issue #, if available

#1133

Description of changes

Description of how you validated changes

Checklist

  • Adheres to the development guidelines
  • Add/update unit tests using:
  • Add/update integration tests
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Do these changes include any template validations?
    • Did the newly validated properties support intrinsics prior to adding the validations? (If unsure, please review Intrinsic Functions before proceeding).
      • Does the pull request ensure that intrinsics remain functional with the new validations?

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hoffa hoffa requested a review from a team as a code owner November 21, 2022 21:44
GavinZZ
GavinZZ approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@hoffa hoffa enabled auto-merge (squash) November 21, 2022 21:48
@hoffa hoffa merged commit 75a873a into aws:develop Nov 21, 2022
@hoffa hoffa deleted the ensure-schema branch November 21, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xazhao xazhao xazhao approved these changes

@GavinZZ GavinZZ GavinZZ approved these changes

@aahung aahung aahung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hoffa @aahung @GavinZZ @xazhao