Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skeleton Lambda Events Schema #2629

Merged
merged 2 commits into from
Nov 21, 2022
Merged

Skeleton Lambda Events Schema #2629

merged 2 commits into from
Nov 21, 2022

Conversation

GavinZZ
Copy link
Contributor

@GavinZZ GavinZZ commented Nov 21, 2022

Issue #, if available

#1133

Description of changes

Description of how you validated changes

Checklist

  • Adheres to the development guidelines
  • Add/update unit tests using:
  • Add/update integration tests
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Do these changes include any template validations?
    • Did the newly validated properties support intrinsics prior to adding the validations? (If unsure, please review Intrinsic Functions before proceeding).
      • Does the pull request ensure that intrinsics remain functional with the new validations?

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@GavinZZ GavinZZ requested a review from a team as a code owner November 21, 2022 21:33
Copy link
Contributor

@acristin acristin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll followup with more precise types for all of the Unknowns, right?

@GavinZZ
Copy link
Contributor Author

GavinZZ commented Nov 21, 2022

We'll followup with more precise types for all of the Unknowns, right?

Yes, wil continue to work on it after this is merged.

@GavinZZ GavinZZ merged commit 92e216e into develop Nov 21, 2022
@hoffa hoffa deleted the lambda_events_schema branch November 21, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants