Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support adding events to existing functions (take 2) #1917

Closed
wants to merge 2 commits into from

Conversation

Jacco
Copy link
Contributor

@Jacco Jacco commented Feb 7, 2021

Issue #866:
Support adding events to existing functions

Description of changes:

  • class SamEventsResource(SamResourceMacro) to share events handling with SamFunction, SamApplication and SamFunctionReference
  • class SamFunction now inherits from SamEventsResource
  • class SamStackFunctionReference(SamResourceMacro) helper function reference for sar
  • class SamFunctionReference(SamEventsResource) introduced for use as new sam resource that supports events
  • class SamApplication now inherits from SamEventsResource so events can be used on it

Description of how you validated changes:
Added two translator tests and two integration tests

Checklist:

  • Write/update tests
  • make pr passes
  • Update documentation
  • Verify transformed template deploys and application functions as expected

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hawflau hawflau requested review from a team, hawflau, lucashuy and moelasmar and removed request for a team and lucashuy June 14, 2022 23:57
@jfuss
Copy link
Contributor

jfuss commented Jul 25, 2022

@Jacco Just wanted to first say, thank you for spending the time on this. Given how old this is and conflicting files, I am going to close it.

I think this still could be powerful but it is unclear how we will want to achieve this. We are looking into what is next for SAM (#2319), which I think this could be a good candidate to make sure we solve (at the very least) within that context/issue.

@jfuss jfuss closed this Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants