Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Helm chart option to set POD container name #7384

Merged
merged 10 commits into from
Dec 5, 2024
Merged

Conversation

udhos
Copy link
Contributor

@udhos udhos commented Nov 14, 2024

Fixes #7383

Description

Helm chart option to set POD container name.

Several of our observability tools rely on POD container name and "controller" is too much generic.

This change adds this option to values.yaml:

controller:
  # -- Distinguishing container name (containerName: karpenter-controller).
  containerName: controller

How was this change tested?

Using "helm template" to check it defaults to current setting (controller) and allows defining a new container name.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@udhos udhos requested a review from a team as a code owner November 14, 2024 20:33
@udhos udhos requested a review from ellistarn November 14, 2024 20:33
Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 382ebe0
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/674545e82838c9000817d0c2
😎 Deploy Preview https://deploy-preview-7384--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@udhos udhos requested a review from Vacant2333 November 21, 2024 03:11
Copy link
Contributor

@Vacant2333 Vacant2333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

Copy link
Contributor

github-actions bot commented Dec 5, 2024

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-382ebe09b4d15c08376e1c5c7ef92b18ae148b75.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-382ebe09b4d15c08376e1c5c7ef92b18ae148b75" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12023479404

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 142 unchanged lines in 17 files lost coverage.
  • Overall coverage decreased (-17.3%) to 65.122%

Files with Coverage Reduction New Missed Lines %
pkg/providers/instancetype/instancetype.go 1 95.98%
pkg/test/options.go 1 93.33%
pkg/test/nodeclass.go 1 98.98%
pkg/test/environment.go 2 96.06%
pkg/providers/instancetype/types.go 3 96.67%
pkg/controllers/controllers.go 4 0.0%
pkg/providers/amifamily/ami.go 5 94.44%
pkg/controllers/nodeclass/hash/controller.go 5 70.49%
pkg/operator/options/options.go 6 74.29%
pkg/controllers/nodeclass/termination/controller.go 6 59.68%
Totals Coverage Status
Change from base Build 11944648017: -17.3%
Covered Lines: 5732
Relevant Lines: 8802

💛 - Coveralls

@jonathan-innis jonathan-innis merged commit 9955c1e into aws:main Dec 5, 2024
35 of 37 checks passed
asherf added a commit to asherf/karpenter-provider-aws that referenced this pull request Dec 16, 2024
@asherf
Copy link

asherf commented Dec 16, 2024

this breaks when setting a different container name, fix: #7533

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart values option to set POD container name
5 participants