Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Drop unused files from aws/karpenter-provider-aws repo #5312

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

jonathan-innis
Copy link
Contributor

Fixes #N/A

Description

This drops the following sets of files from the repo:

  1. Publish Test Tools Workflow - This workflow was used for pushing an updated docker image when we were using Tekton for our E2E testing. We have since dropped support for Tekton; so, we can remove these files from the repo
  2. Provisioner Examples - These examples should have been dropped at the v1alpha5 migration on v0.33.x. These examples still exist on older tagged versions of the repo but shouldn't exist on the latest version
  3. Sync Cluster - These scripts were artifacts of the old SQS-based Tekton workflows. These have since been replaced
  4. Dockerfile and push-docker.sh - This script was used in the Publish Test Tools workflow that was mentioned earlier for pushing newer versions of the testing image up to our test ECR for Tekton.

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner December 13, 2023 02:18
@jonathan-innis jonathan-innis enabled auto-merge (squash) December 13, 2023 02:18
Copy link

netlify bot commented Dec 13, 2023

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 12d20af
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65791490517ca0000841e764

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7189876908

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.489%

Totals Coverage Status
Change from base Build 7189741306: 0.0%
Covered Lines: 4918
Relevant Lines: 5962

💛 - Coveralls

@jonathan-innis jonathan-innis merged commit 53e8963 into aws:main Dec 13, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants