Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: visual basic related bugs #763

Merged
merged 5 commits into from
Jul 1, 2022
Merged

fix: visual basic related bugs #763

merged 5 commits into from
Jul 1, 2022

Conversation

cslong
Copy link
Contributor

@cslong cslong commented Jul 1, 2022

Description

fix missing set language when initializing project rewriter from the ide extension
update codelyzer references with additional fix for AnalyzeFile aws/codelyzer@154f897


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cslong cslong changed the title Longachr fixes fix: set language on project rewriter initialization Jul 1, 2022
Beau-Gosse-dev
Beau-Gosse-dev previously approved these changes Jul 1, 2022
Copy link
Contributor

@Beau-Gosse-dev Beau-Gosse-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was GetReferencesForProject just refactoring, or is there a functional change in there that I missed? If it's not too hard, you could add unit tests for GetReferencesForProject, but LGTM

@cslong cslong changed the title fix: set language on project rewriter initialization fix: visual basic related bugs Jul 1, 2022
@cslong cslong merged commit abdb1dc into main Jul 1, 2022
@cslong cslong deleted the longachr-fixes branch July 1, 2022 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants