chore: private services env compatibility checker, only enable if enabled 🤦 #4150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannyrandall
requested review from
KollaAdithya
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## mainline #4150 +/- ##
=========================================
Coverage 69.10% 69.11%
=========================================
Files 251 251
Lines 36037 36042 +5
Branches 264 264
=========================================
+ Hits 24904 24910 +6
+ Misses 9929 9927 -2
- Partials 1204 1205 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
huanjani
previously approved these changes
Nov 1, 2022
Lou1415926
reviewed
Nov 1, 2022
|
🍕 Here are the new binary sizes!
|
iamhopaul123
reviewed
Nov 4, 2022
iamhopaul123
reviewed
Nov 4, 2022
efekarakus
reviewed
Nov 16, 2022
| @@ -186,6 +191,9 @@ func (s RequestDrivenWebService) applyEnv(envName string) (workloadManifest, err | |||
|
|
|||
| func (s *RequestDrivenWebService) requiredEnvironmentFeatures() []string { | |||
There was a problem hiding this comment.
This has nothing to do with your PR but it's pretty strange to me that this method:
belongs to *DynamicWorkloadManifest 🤔 it doesn't seem relevant to a "dynamic" aspect.
I'd have expected it to be part of the individual Manifest types.
iamhopaul123
added
the
do-not-merge
Lou1415926
removed
the
do-not-merge
Lou1415926
added
the
do-not-merge
Lou1415926
removed
the
do-not-merge
iamhopaul123
added
do-not-merge
efekarakus
added
the
do-not-merge
bvtujo
removed
the
do-not-merge
Lou1415926
added
do-not-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.