Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compact JSON representation #958

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Compact JSON representation #958

merged 1 commit into from
Dec 6, 2018

Conversation

pickfire
Copy link
Contributor

@pickfire pickfire commented Oct 5, 2018

Issue #, if available:

Description of changes: Compact JSON for Response, this removes unneeded whitespaces in response.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Oct 5, 2018

Codecov Report

Merging #958 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #958   +/-   ##
=======================================
  Coverage   95.52%   95.52%           
=======================================
  Files          27       27           
  Lines        4449     4449           
  Branches      558      558           
=======================================
  Hits         4250     4250           
  Misses        128      128           
  Partials       71       71
Impacted Files Coverage Δ
chalice/app.py 96.75% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4f8a79...55d1a8a. Read the comment docs.

Copy link
Contributor

@joguSD joguSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed this works when actually deployed.
With PR:

> curl $(chalice url)    
{"hello":"world"}%    

Current master:

> curl $(chalice url)  
{"hello": "world"}%

Considering this did break assertions we were making, I'm wondering if we should consider this a breaking change and make this configurable instead.

@joguSD joguSD merged commit 4fa7a58 into aws:master Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants