Add support for pip 18 #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the if/else logic so it will work with new versions without changes.
|
Should we also bump our ceiling on pip version to <=18? EDIT: missed the setup.py update. |
jamesls
approved these changes
Jul 23, 2018
Codecov Report
@@ Coverage Diff @@
## master #908 +/- ##
=======================================
Coverage 95.48% 95.48%
=======================================
Files 27 27
Lines 4449 4449
Branches 558 558
=======================================
Hits 4248 4248
Misses 129 129
Partials 72 72
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for pip 18
Change the if/else logic so it will work with new versions without
changes.