-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for 3.6 pipelines #858
Conversation
This allows pipelines to be made for projects using python 3.6. This can be done because CodeBuild recently added a 3.6.5 container.
0bbab6f
to
b06a4f8
Compare
Codecov Report
@@ Coverage Diff @@
## master #858 +/- ##
======================================
Coverage 95.1% 95.1%
======================================
Files 22 22
Lines 3838 3838
Branches 493 493
======================================
Hits 3650 3650
Misses 122 122
Partials 66 66
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🚢
Can you please update the docs as well? The topic and CLI help docs are incorrect now. |
assert template['Parameters']['CodeBuildImage']['Default'] == \ | ||
'aws/codebuild/python:3.6.5' | ||
|
||
def test_invalid_python_throws_error(self): | ||
# This test can be removed when there is a 3.6 codebuild image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment is out of date.
This allows pipelines to be made for projects using python 3.6. This
can be done because CodeBuild recently added a 3.6.5 container.
Available images, for reference: https://docs.aws.amazon.com/codebuild/latest/userguide/build-env-ref-available.html