Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 3.6 pipelines #858

Merged
merged 1 commit into from
Jun 1, 2018

Conversation

JordonPhillips
Copy link
Member

@JordonPhillips JordonPhillips commented Jun 1, 2018

This allows pipelines to be made for projects using python 3.6. This
can be done because CodeBuild recently added a 3.6.5 container.

Available images, for reference: https://docs.aws.amazon.com/codebuild/latest/userguide/build-env-ref-available.html

This allows pipelines to be made for projects using python 3.6. This
can be done because CodeBuild recently added a 3.6.5 container.
@codecov-io
Copy link

Codecov Report

Merging #858 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #858   +/-   ##
======================================
  Coverage    95.1%   95.1%           
======================================
  Files          22      22           
  Lines        3838    3838           
  Branches      493     493           
======================================
  Hits         3650    3650           
  Misses        122     122           
  Partials       66      66
Impacted Files Coverage Δ
chalice/pipeline.py 98.37% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d32229...b06a4f8. Read the comment docs.

Copy link
Contributor

@kyleknap kyleknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚢

@JordonPhillips JordonPhillips merged commit 70ad44d into aws:master Jun 1, 2018
@jamesls
Copy link
Member

jamesls commented Jun 1, 2018

Can you please update the docs as well? The topic and CLI help docs are incorrect now.

assert template['Parameters']['CodeBuildImage']['Default'] == \
'aws/codebuild/python:3.6.5'

def test_invalid_python_throws_error(self):
# This test can be removed when there is a 3.6 codebuild image
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment is out of date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants