Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for authenticated routes #75

Merged
merged 1 commit into from
Aug 1, 2016
Merged

Add support for authenticated routes #75

merged 1 commit into from
Aug 1, 2016

Conversation

JamieCressey
Copy link

Closes #14

@JamieCressey JamieCressey changed the title Custom auth Add support for authenticated routes Jul 30, 2016
@jamesls
Copy link
Member

jamesls commented Aug 1, 2016

Thanks for the pull request. Could you update the README with an example of how to use this new functionality?

@@ -1,2 +1,3 @@
pytest==2.9.2
py==1.4.31
pygments==2.1.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intentional?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't get the tests to run locally without it. It can be revert if
I've missed something?

On 1 August 2016 at 19:26, James Saryerwinnie [email protected]
wrote:

In requirements-test.txt
#75 (comment):

@@ -1,2 +1,3 @@
pytest==2.9.2
py==1.4.31
+pygments==2.1.3

Was this intentional?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/awslabs/chalice/pull/75/files/fd42f38a4ab7869e04bbb28d3c99010343563fcb#r73027646,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGKdwsABbPTmARMaB4cyDrJs7pGojm98ks5qbjppgaJpZM4JYx-y
.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I'm running into this as well: https://travis-ci.org/awslabs/chalice/builds/148965791

Let's go ahead and keep this in here.

@JamieCressey
Copy link
Author

JamieCressey commented Aug 1, 2016

@jamesls README updated and rebased

@jamesls jamesls merged commit ef25f68 into aws:master Aug 1, 2016
@jamesls
Copy link
Member

jamesls commented Aug 1, 2016

Merged, thanks for the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants