Failed iam role creation #632
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nplutt
commented
Dec 6, 2017
| @@ -732,8 +732,10 @@ def test_can_create_app_packager_with_no_autogen(tmpdir): | |||
| appdir = _create_app_structure(tmpdir) | |||
There was a problem hiding this comment.
From what I could tell it doesn't look like this test test_can_create_app_packager_with_no_autogen has anything to do with the deploy --no-autogen-policy command so I changed it to create the policy automatically so as not to trigger the RuntimeError. If it does let me know and I can make whatever changes are needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug #565.
So there ended up being a couple issue that I fixed here, first being bug #565 which was fixed by making a change to the
awsclient.pyfile.The second issue that I discovered while working on this bug was the following. If you do:
$ chalice new-project muck $ cd muck $ chalice deploy --no-autogen-policyThe same bug happens because the
policy-env.jsonfile does not exist. This results in a policy document of:being uploaded which throws a
MalformedPolicyDocumenterror. In order to fix this issue I made changes to thedeployer.pyfile. I removed the default policy and now raise aRuntimeErrorand alert the user to the fact that they do not have apolicy-env.jsonfile.The last change that I made was to handle malformed json by adding nicer logging modeled after the config file loader.
Thanks!