Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for both api_key_required AND authorizer on routes #473

Closed
wants to merge 2 commits into from

Conversation

nelsonlj
Copy link
Contributor

Changed to support routes that need both an api_key and an authorizer.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Changed to support routes that need both an api_key and an authorizer.
@codecov-io
Copy link

codecov-io commented Aug 12, 2017

Codecov Report

Merging #473 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #473      +/-   ##
==========================================
+ Coverage   94.01%   94.04%   +0.03%     
==========================================
  Files          18       18              
  Lines        2940     2941       +1     
  Branches      380      381       +1     
==========================================
+ Hits         2764     2766       +2     
  Misses        129      129              
+ Partials       47       46       -1
Impacted Files Coverage Δ
chalice/deploy/swagger.py 100% <100%> (+1.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8313fd0...da435bd. Read the comment docs.

@jamesls
Copy link
Member

jamesls commented Aug 17, 2017

Thanks for the pull request. Per our Contributing guidelines we just need to get a test added for this before this can get merged.

Would you be able to add a test in tests/unit/deploy/test_swagger.py for this fix?

jamesls added a commit to jamesls/chalice that referenced this pull request Sep 5, 2017
@jamesls
Copy link
Member

jamesls commented Sep 5, 2017

Rebased against master and added a test for this here: #473

Thanks again for the pull request!

@jamesls jamesls closed this Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants