Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate route cannot be the empty string #432

Merged
merged 2 commits into from
Jul 26, 2017

Conversation

jamesls
Copy link
Member

@jamesls jamesls commented Jul 26, 2017

This results in an opaque error message when you try to deploy.

@jamesls jamesls requested review from stealthycoin and kyleknap July 26, 2017 21:26
@codecov-io
Copy link

codecov-io commented Jul 26, 2017

Codecov Report

Merging #432 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #432      +/-   ##
=========================================
+ Coverage   93.59%   93.6%   +<.01%     
=========================================
  Files          18      18              
  Lines        2858    2860       +2     
  Branches      374     375       +1     
=========================================
+ Hits         2675    2677       +2     
  Misses        132     132              
  Partials       51      51
Impacted Files Coverage Δ
chalice/deploy/deployer.py 93.71% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6db6dc...b43f6ab. Read the comment docs.

jamesls added 2 commits July 26, 2017 14:59
This results in an opaque error message when you try to deploy.
@jamesls jamesls merged commit b43f6ab into aws:master Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants