Use absolute path for project_dir context object #414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --project-dir option was not correctly calculating the path to open up the config file. This would result in valid `project_dir` values raising an OSError and presenting this error message to the user: ``` $ ls drwxr-xr-x 6 chris staff 204B Jul 12 17:24 sample/ ... ... $ chalice --project-dir sample deploy Unable to load the project config file. Are you sure this is a chalice project? ```
Codecov Report
@@ Coverage Diff @@
## master #414 +/- ##
==========================================
+ Coverage 93.54% 93.58% +0.03%
==========================================
Files 18 18
Lines 2805 2804 -1
Branches 369 368 -1
==========================================
Hits 2624 2624
Misses 133 133
+ Partials 48 47 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --project-dir option was not correctly calculating the path to open up the
config file. This would result in valid
project_dirvalues raising an OSErrorand presenting this error message to the user: