Fix crash when analyzer encounters listcomp/genexprs #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right, fixing this. I forgot that in py27 listcomps don't actually create a new child scope. |
Internally, python creates a function for listcomps/genexprs so we treat it similarly. There's a new child scope and therefore a new symbol table we need to fetch. The only tricky part is that python names this function 'genexpr' and 'listcomp' even in the case of multiple genexprs and listcomps. We're not analyzing the `generators` attr of the nodes, but we will need to take that into account when we do. For now it doesn't matter.
Codecov Report
@@ Coverage Diff @@
## master #392 +/- ##
=========================================
+ Coverage 92.17% 92.27% +0.1%
=========================================
Files 18 18
Lines 2440 2460 +20
Branches 320 323 +3
=========================================
+ Hits 2249 2270 +21
+ Misses 142 141 -1
Partials 49 49
Continue to review full report at Codecov.
|
stealthycoin
approved these changes
Jun 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally, python creates a function for listcomps/genexprs
so we treat it similarly. There's a new child scope and therefore
a new symbol table we need to fetch. The only tricky part is that
python names this function 'genexpr' and 'listcomp' even in the
case of multiple genexprs and listcomps. We're not analyzing the
generatorsattr of the nodes, but we will need to take thatinto account when we do. For now it doesn't matter.
Closes #263