Adding support for common RESTful HTTP response codes #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, I think this will be a great addition. I'll need to update one of the unit tests that verifies all the API calls that are made for a deploy command, it's currently failing because of the new API calls we're making to set up the new errors. Now that the repo's public, I need to get travis set up so we can get this test feedback earlier. |
|
Any news on the unit tests, @jamesls? Happy to help with the Travis setup in anyway I can. |
|
@JamieCressey seems ready to go: |
|
Sorry for the delay, I've been OOTO until today. I'm taking a look now. |
|
Added test and rebased against master. Merged via fef8f13. Thanks again for the pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34