Changed autogen_policy default value from True to None #367
Conversation
Codecov Report
@@ Coverage Diff @@
## master #367 +/- ##
==========================================
+ Coverage 90.73% 90.87% +0.13%
==========================================
Files 18 18
Lines 2148 2148
Branches 276 276
==========================================
+ Hits 1949 1952 +3
+ Misses 146 145 -1
+ Partials 53 51 -2
Continue to review full report at Codecov.
|
|
There's also another PR for this: https://github.com/awslabs/chalice/pull/281/files It removes the default of |
Updated some test related to the autogen policy on a deployment. Added tests to ensure that the config file value is taken over the default if no autogen-policy is specified on the command line.
stealthycoin
force-pushed
the
bugfix-autogen-policy
branch
from
9b26bf6 to
4b40375
Compare
There was a problem hiding this comment.
Looks good. Like the approach. I think it would also be worth to add the following test cases if there is not any:
-
The default value for
autogen_policywhen nothing is provide to thecreate_config_obj() -
Make sure you can manually override whatever is set in the
config.jsonby providing it straight tocreate_config_obj()
CHANGELOG.rst
Outdated
| @@ -9,6 +9,9 @@ Next Release (TBD) | |||
| redeployments of chalice applications and in the CloudFormation template | |||
| generated by ``chalice package`` | |||
| (`#339 <https://github.com/awslabs/chalice/issues/339>`__) | |||
| * Fix autogen_policy in config being ignored | |||
There was a problem hiding this comment.
Probably want to make autogen_policy be a code literal in the changelog.
|
Added those tests cases. |
CHANGELOG.rst
Outdated
| @@ -9,7 +9,7 @@ Next Release (TBD) | |||
| redeployments of chalice applications and in the CloudFormation template | |||
| generated by ``chalice package`` | |||
| (`#339 <https://github.com/awslabs/chalice/issues/339>`__) | |||
| * Fix autogen_policy in config being ignored | |||
| * Fix `autogen_policy` in config being ignored | |||
There was a problem hiding this comment.
Oh it's rst not markdown. That gets me as well. Probably want to use `` instead of `
stealthycoin
force-pushed
the
bugfix-autogen-policy
branch
from
ae3ab22 to
1476591
Compare
Fixes #354
cc @kyleknap @jamesls
closes #281