Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added IamAuthorizer class to support AWS_IAM authorizor on API Gateway #334

Merged
merged 3 commits into from
May 23, 2017

Conversation

zepplen
Copy link
Contributor

@zepplen zepplen commented May 11, 2017

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #334 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #334      +/-   ##
=========================================
+ Coverage   89.87%   89.9%   +0.03%     
=========================================
  Files          18      18              
  Lines        1986    1992       +6     
  Branches      240     240              
=========================================
+ Hits         1785    1791       +6     
  Misses        147     147              
  Partials       54      54
Impacted Files Coverage Δ
chalice/__init__.py 100% <ø> (ø) ⬆️
chalice/app.py 95.23% <100%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5ddc5c...147361c. Read the comment docs.

@codecov-io
Copy link

codecov-io commented May 11, 2017

Codecov Report

Merging #334 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #334      +/-   ##
=========================================
+ Coverage   89.87%   89.9%   +0.03%     
=========================================
  Files          18      18              
  Lines        1986    1992       +6     
  Branches      240     240              
=========================================
+ Hits         1785    1791       +6     
  Misses        147     147              
  Partials       54      54
Impacted Files Coverage Δ
chalice/__init__.py 100% <ø> (ø) ⬆️
chalice/app.py 95.23% <100%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5ddc5c...147361c. Read the comment docs.

@jamesls
Copy link
Member

jamesls commented May 15, 2017

Awesome! Thanks for the pull request, I'm trying this out now.

@jamesls jamesls self-requested a review May 15, 2017 20:58
Copy link
Member

@jamesls jamesls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I made a small change and renamed IamAuthorizer to IAMAuthorizer to be consistent with our naming conventions. Otherwise looks good, thanks again for the pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants